Skip to content

chore(templates): remove obsolete .taprc file - #747

Merged
Eomm merged 2 commits into
fastify:masterfrom
faustman:patch-1
Jul 20, 2024
Merged

Eomm merged 2 commits into
fastify:masterfrom
faustman:patch-1

Conversation

@faustman

Copy link
Copy Markdown
Contributor

Hi guys,

I'm recently playing with a new project and mentioned that you migrated from tap to node:assert, but .taprc is still in place.
This PR just removes unnecessary __taprc files from templates.

Thank you!

Checklist

@jean-michelet jean-michelet left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @faustman!

Code coverage and JIT transpiling are handled with c8 and ts-node:

test: 'npm run build:ts && tsc -p test/tsconfig.json && c8 node --test -r ts-node/register "test/**/*.ts"',

So lgtm (if the tests pass)!

@jean-michelet

Copy link
Copy Markdown
Member

These docs still refer to tap, can you update them please?

@faustman

Copy link
Copy Markdown
Contributor Author

I've updated README.
Can we run a test workflow, please?

@jean-michelet

Copy link
Copy Markdown
Member

Don't have the rights on this repo unfortunately.

Can you @mcollina?

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@faustman

Copy link
Copy Markdown
Contributor Author

Thank you guys!
Everything looks fine, it's ready to merge)

@Eomm
Eomm merged commit f55734c into fastify:master Jul 20, 2024
@Eomm

Eomm commented Jul 20, 2024

Copy link
Copy Markdown
Member

relates to #682

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants