Skip to content

Remove renderSubtreeIntoContainer_DO_NOT_USE#28526

Merged
kassens merged 1 commit intofacebook:mainfrom
kassens:pr28526
Mar 12, 2024
Merged

Remove renderSubtreeIntoContainer_DO_NOT_USE#28526
kassens merged 1 commit intofacebook:mainfrom
kassens:pr28526

Conversation

@kassens
Copy link
Copy Markdown
Member

@kassens kassens commented Mar 8, 2024

Once D54648741 lands internally, we no longer need this shim.

NOTE: There is still some work left to remove the unstable_renderSubtreeIntoContainer export.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 8, 2024
@react-sizebot
Copy link
Copy Markdown

Comparing: 338dddc...b7cde9e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.10 kB 177.10 kB = 55.20 kB 55.20 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.64 kB 177.64 kB = 55.53 kB 55.53 kB
facebook-www/ReactDOM-prod.classic.js = 594.34 kB 594.34 kB = 104.96 kB 104.96 kB
facebook-www/ReactDOM-prod.modern.js = 577.60 kB 577.60 kB = 102.02 kB 102.02 kB
test_utils/ReactAllWarnings.js Deleted 66.60 kB 0.00 kB Deleted 16.28 kB 0.00 kB
facebook-www/shims/renderSubtreeIntoContainer_DO_NOT_USE.js Deleted 0.31 kB 0.00 kB Deleted 0.23 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 66.60 kB 0.00 kB Deleted 16.28 kB 0.00 kB
facebook-www/shims/renderSubtreeIntoContainer_DO_NOT_USE.js Deleted 0.31 kB 0.00 kB Deleted 0.23 kB 0.00 kB

Generated by 🚫 dangerJS against b7cde9e

@kassens kassens merged commit eb33bd7 into facebook:main Mar 12, 2024
@kassens kassens deleted the pr28526 branch March 12, 2024 15:31
github-actions Bot pushed a commit that referenced this pull request Mar 12, 2024
Since D54648741 we no longer need this shim.

NOTE: There is still some work left to remove the
`unstable_renderSubtreeIntoContainer` export.

DiffTrain build for [eb33bd7](eb33bd7)
gnoff added a commit to gnoff/next.js that referenced this pull request Mar 25, 2024
- facebook/react#28596
- facebook/react#28625
- facebook/react#28616
- facebook/react#28491
- facebook/react#28583
- facebook/react#28427
- facebook/react#28613
- facebook/react#28599
- facebook/react#28611
- facebook/react#28610
- facebook/react#28606
- facebook/react#28598
- facebook/react#28549
- facebook/react#28557
- facebook/react#28467
- facebook/react#28591
- facebook/react#28459
- facebook/react#28590
- facebook/react#28564
- facebook/react#28582
- facebook/react#28579
- facebook/react#28578
- facebook/react#28521
- facebook/react#28550
- facebook/react#28576
- facebook/react#28577
- facebook/react#28571
- facebook/react#28572
- facebook/react#28560
- facebook/react#28569
- facebook/react#28573
- facebook/react#28546
- facebook/react#28568
- facebook/react#28562
- facebook/react#28566
- facebook/react#28565
- facebook/react#28559
- facebook/react#28508
- facebook/react#20432
- facebook/react#28555
- facebook/react#24730
- facebook/react#28472
- facebook/react#27991
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Since D54648741 we no longer need this shim. 

NOTE: There is still some work left to remove the
`unstable_renderSubtreeIntoContainer` export.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
Since D54648741 we no longer need this shim.

NOTE: There is still some work left to remove the
`unstable_renderSubtreeIntoContainer` export.

DiffTrain build for commit eb33bd7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants