Skip to content

fix(loans): scanner focus and natural copy ordering - #339

Merged
fabiodalez-dev merged 1 commit into
mainfrom
codex/fix-discussion-238-loan-form-copies
Aug 13, 2026
Merged

fabiodalez-dev merged 1 commit into
mainfrom
codex/fix-discussion-238-loan-form-copies

Conversation

@fabiodalez-dev

Copy link
Copy Markdown
Owner

Summary

Addresses the latest feedback in Discussion #238:

  • dismisses the previous loan success notice as soon as the next form is edited, removing stale created/pdf URL flags
  • fully tears down the camera video and restores focus to the scan trigger without reopening the mobile keyboard
  • naturally sorts physical-copy inventory codes in the book table and copy-label PDF (C2 before C10)
  • adds regression coverage for the form lifecycle, scanner teardown/focus, table ordering, and PDF page ordering

Discussion: #238 (comment)

Verification

  • php tests/discussion-238-followup.unit.php — 18 passed
  • PHP lint on changed PHP files
  • frontend ESLint
  • production webpack build
  • JavaScript syntax checks
  • git diff --check
  • PHPStan pre-commit hook — no errors

The DB-backed inventory test was skipped locally because this isolated worktree has no MySQL credentials; GitHub CI provides its MySQL service.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@fabiodalez-dev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d7901aee-9873-4bdd-845b-7f3e4fffac72

📥 Commits

Reviewing files that changed from the base of the PR and between 69301d0 and 585a33f.

📒 Files selected for processing (8)
  • app/Controllers/LibriController.php
  • app/Models/CopyRepository.php
  • app/Views/prestiti/crea_prestito.php
  • frontend/js/copy-scanner.js
  • public/assets/copy-scanner.bundle.js
  • tests/discussion-238-followup.unit.php
  • tests/full-test.spec.js
  • tests/label-pdf-content.spec.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fabiodalez-dev
fabiodalez-dev merged commit d015299 into main Aug 13, 2026
6 checks passed
fabiodalez-dev added a commit that referenced this pull request Aug 13, 2026
Stable 0.7.59. Integrates the four feature/fix PRs plus the review hardening and security pass. Full required-check matrix green.
@fabiodalez-dev
fabiodalez-dev deleted the codex/fix-discussion-238-loan-form-copies branch August 13, 2026 10:57
Himura2la pushed a commit to hackerembassy/Pinakes that referenced this pull request Aug 13, 2026
Rename migrate_0.7.58.sql -> migrate_0.7.59-rc.1.sql (and its behavioural test).
0.7.58 is already released, so a migration named after it is version-skipped for
installs already on 0.7.58 (updater runs migrationVersion > fromVersion). Naming
it after the RC that ships it makes it run on the RC upgrade and on the eventual
stable 0.7.59. Bump version.json to 0.7.59-rc.1.

Audited: none of the other bundled changes (fabiodalez-dev#335 settings, fabiodalez-dev#337 badge helpers,
fabiodalez-dev#339 copy ordering) require a migration — every new DB read targets pre-existing
columns/ENUM values or passes a safe default, and app.timezone self-heals on save.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant