Fix tracking of applied operator patches per walk - #658
Closed
rrb3942 wants to merge 2 commits into
Closed
Conversation
This was referenced May 22, 2024
Member
|
Closing in flavor of #659 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking if an operator overload patch was applied was not happening per-walk of the ast tree. This lead to re-running patchers a thousand times if any operator overload applied.
I added a
Reset()method to the operator patcher that can be called before every walk to reset the tracking state.I don't think the outer loop limit of 1000 is required anymore since state is being properly tracked. I can revert this patch and re-push if you want to keep the limit.
This is part of the problem for issue #637