Include ref.parent matches in events by-reference navigation#2280
ref.parent matches in events by-reference navigation#2280Conversation
|
|
ref.parent matches in events by-reference navigation
Co-authored-by: niemyjski <1020579+niemyjski@users.noreply.github.com>
e666187 to
8f5e641
Compare
# Conflicts: # src/Exceptionless.Web/Controllers/EventController.cs
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae3cc52eb3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f152edde5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 775c14f17c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f0dd46364
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a507d669da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85e61cecba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Follow-up reviewer audit complete on head Feedback classification:
Thermo-nuclear review of the complete current branch-vs-main diff found and fixed a partial-update risk where Local verification: backend build passed with 0 warnings/errors; compatibility tests 3/3; migration task-result tests 4/4; service-backed migration 1/1; free-plan ingestion 1/1; organization/project by-reference endpoints 2/2; query validator 70/70; frontend unit tests 332/332; focused reference-page tests 3/3; focused premium-filter tests 4/4; Authoritative GitHub Actions run |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e5f263221
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7a0b3764c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
/events/by-ref/{referenceId}only matchedreference:{id}, so child events that stored their relationship inref.parentcould not be reached through Parent navigation.Root cause
referencefield.ref.parentto the query initially made the route premium-only because dynamic reference fields were classified as premium.idx.parent-reven though test fixtures did.Changes
reference:{id}orref.parent:{id}in organization- and project-scoped handlers and frontend navigation.@ref:parentfor free-plan events; arbitrary custom data remains unindexed.idx.parent-rvalues for retained events without overwriting existing indexes.ref.<name>query fields.ref.<name>and suppress unsafe/invalid filter controls.origin/maininto the PR branch.Verification
dotnet build tests/Exceptionless.Tests/Exceptionless.Tests.csproj --no-restore --disable-build-servers -m:1— 0 warnings, 0 errors.StringExtensionsTests— 43 passed.PersistentEventQueryValidatorTests— 70 passed.EventPipelineTests— 60 passed, 1 intentional skip.EventEndpointTests— 104 passed.BackfillParentReferencesMigrationTests— passed against Elasticsearch.npm run validate— passed (Prettier, ESLint, and Svelte check with 0 errors/warnings).dotnet format --verify-no-changes— passed.Compatibility and scope
identifierroute constraint and event validation to 8–100 letters, digits, or hyphens.idx.parent-rsearch field; arbitrary dynamic reference fields remain premium-only.