Skip to content

Add support for IConfiguration when using netstandard.#307

Merged
niemyjski merged 2 commits intomainfrom
feature/iconfiguration-support
May 18, 2023
Merged

Add support for IConfiguration when using netstandard.#307
niemyjski merged 2 commits intomainfrom
feature/iconfiguration-support

Conversation

@niemyjski
Copy link
Copy Markdown
Member

@niemyjski niemyjski commented May 18, 2023

This allows for other consumers using .NET Core clients like WPF to use IConfiguration.

ExceptionlessClient.Default.Configuration.ReadFromConfiguration(config);
ExceptionlessClient.Default.Register();

We are taking a dep on the LTS abstraction, it would be great to automatically read from configuration but:

  1. We would have to take out much larger dependencies..
  2. We wouldn't know your naming scheme of your configuration files...

@niemyjski niemyjski requested a review from ejsmith May 18, 2023 11:57
@niemyjski niemyjski self-assigned this May 18, 2023
@niemyjski niemyjski merged commit 092ec02 into main May 18, 2023
@niemyjski niemyjski deleted the feature/iconfiguration-support branch May 18, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant