Conversation
… are deployed on a server
niemyjski
commented
May 3, 2023
Comment on lines
+272
to
+275
| if (_flushMutex != null) { | ||
| _flushMutex.Close(); | ||
| _flushMutex = null; | ||
| } |
Member
Author
There was a problem hiding this comment.
I added this, I don't see how it can hurt.
niemyjski
commented
May 3, 2023
Comment on lines
+315
to
+333
| #if NET45 | ||
| var security = new MutexSecurity(); | ||
| var allowEveryoneRule = new MutexAccessRule(new SecurityIdentifier(WellKnownSidType.WorldSid, null), MutexRights.FullControl, AccessControlType.Allow); | ||
| security.AddAccessRule(allowEveryoneRule); | ||
|
|
||
| string name = GetFileBasedMutexName(fileNameOrPath); | ||
|
|
||
| try { | ||
| return new Mutex(false, name, out bool _, security); | ||
| } catch (Exception ex) { | ||
| if (ex is SecurityException || ex is UnauthorizedAccessException || ex is NotSupportedException || ex is NotImplementedException) { | ||
| System.Diagnostics.Trace.WriteLine("Exceptionless: Error creating global mutex falling back to previous implementation: {0}", ex.ToString()); | ||
| return new Mutex(false, nameof(FileExceptionlessLog)); | ||
| } | ||
|
|
||
| System.Diagnostics.Trace.WriteLine("Exceptionless: Error creating global mutex: {0}", ex.ToString()); | ||
| throw; | ||
| } | ||
| #else |
Member
Author
There was a problem hiding this comment.
Global mutexes are not supported on .NET Core or mono. There probably is a case we don't fully cover here.
Member
There was a problem hiding this comment.
According to the docs they are when the mutex name starts with Global\ which you are doing.
ejsmith
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #257