Skip to content

NLog ExceptionlessTarget SetDefaultMinLogLevel#303

Merged
niemyjski merged 1 commit intoexceptionless:mainfrom
snakefoot:main
May 1, 2023
Merged

NLog ExceptionlessTarget SetDefaultMinLogLevel#303
niemyjski merged 1 commit intoexceptionless:mainfrom
snakefoot:main

Conversation

@snakefoot
Copy link
Copy Markdown
Contributor

See also: #260

Copy link
Copy Markdown
Member

@niemyjski niemyjski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@niemyjski niemyjski merged commit 72c51ef into exceptionless:main May 1, 2023
@snakefoot
Copy link
Copy Markdown
Contributor Author

snakefoot commented May 1, 2023

Maybe the override-logic of the call to SetDefaultMinLogLevel on the default-client should be: "only override if not configured already" ? (Similar to the logger-override, that only happens when default null-logger).

@niemyjski
Copy link
Copy Markdown
Member

Yeah we could add an extension or check for that, wouldn't be a bad idea.

@niemyjski
Copy link
Copy Markdown
Member

@snakefoot I just looked at the implementation and it already handles this :)

        public void SetDefaultMinLogLevel(LogLevel minLogLevel) {
            if (!Settings.ContainsKey("@@log:*"))
                Settings.Add("@@log:*", minLogLevel.ToString());
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants