Add Windows environment info collector to the WPF platform#291
Merged
niemyjski merged 2 commits intoexceptionless:mainfrom Jan 27, 2023
Merged
Add Windows environment info collector to the WPF platform#291niemyjski merged 2 commits intoexceptionless:mainfrom
niemyjski merged 2 commits intoexceptionless:mainfrom
Conversation
Contributor
Author
|
Not sure why the tests fail because they green on my machine :) |
Member
|
@mgnslndh can you sign the cla, looks like a flakey test we need to look into. |
Contributor
Author
|
Cloudflare is reporting the clahub as down. Not sure if it is affected by the service outage at Microsoft. I will sign as soon as I can when the site is up and running. |
Contributor
Author
|
@niemyjski I've signed the CLA. The link was wrong but I've submitted another PR fixing that. |
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #290 by add source link to
ExceptionslessWindowsEnvironmentInfoCollectorin the WPF platform project and registering that services to the dependency resolver.Originally posted by @niemyjski in #290 (comment)