Skip to content

bump timeout higher, value shouldn't matter unless latch isn't triggered#276

Merged
niemyjski merged 2 commits intoexceptionless:masterfrom
elachlan:flakytest-willsaveonce
May 10, 2022
Merged

bump timeout higher, value shouldn't matter unless latch isn't triggered#276
niemyjski merged 2 commits intoexceptionless:masterfrom
elachlan:flakytest-willsaveonce

Conversation

@elachlan
Copy link
Copy Markdown
Contributor

@elachlan elachlan commented May 9, 2022

fixes #275

An excessive value for the wait timeout on the second call should not matter, but will help if there is some sort of issue in saving which blows out the time. This value can be reduced if the point of the test is to make sure the save happens in a timely manner.

@elachlan
Copy link
Copy Markdown
Contributor Author

test failure is unrelated.

@niemyjski niemyjski merged commit dc84e00 into exceptionless:master May 10, 2022
@niemyjski
Copy link
Copy Markdown
Member

Thanks for the PR and deep dive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test - PersistedDictionaryTests.WillSaveOnce

2 participants