Skip to content

Internalize client extension methods #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niemyjski merged 1 commit into from
Dec 30, 2021
Merged

Internalize client extension methods #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Exceptionless/Demystifier/ExceptionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace System.Diagnostics
{
public static class ExceptionExtensions
internal static class ExceptionExtensions
{
private static readonly FieldInfo? stackTraceString = typeof(Exception).GetField("_stackTraceString", BindingFlags.Instance | BindingFlags.NonPublic);

Expand Down
12 changes: 6 additions & 6 deletions src/Exceptionless/Extensions/StringExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Exceptionless.Extensions {
public static class StringExtensions {
Copy link
Copy Markdown
Member Author

@niemyjski niemyjski Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ejsmith We couldn't internalize the whole class because AnyWildCardMatches is used by at least 4 client implementations.

public static string ToLowerUnderscoredWords(this string value) {
internal static string ToLowerUnderscoredWords(this string value) {
var builder = new StringBuilder(value.Length + 10);
for (int index = 0; index < value.Length; index++) {
char c = value[index];
Expand All @@ -29,7 +29,7 @@ public static bool AnyWildcardMatches(this string value, IEnumerable<string> pat
return patternsToMatch.Any(pattern => IsPatternMatch(value, pattern, ignoreCase));
}

public static bool IsPatternMatch(this string value, string pattern, bool ignoreCase = true) {
internal static bool IsPatternMatch(this string value, string pattern, bool ignoreCase = true) {
if (pattern == null)
return value == null;

Expand Down Expand Up @@ -60,7 +60,7 @@ public static bool IsPatternMatch(this string value, string pattern, bool ignore
return String.Equals(value, pattern, comparison);
}

public static string[] SplitAndTrim(this string input, params char[] separator) {
internal static string[] SplitAndTrim(this string input, params char[] separator) {
if (String.IsNullOrEmpty(input))
return new string[0];

Expand All @@ -71,7 +71,7 @@ public static string[] SplitAndTrim(this string input, params char[] separator)
return result;
}

public static bool ToBoolean(this string input, bool @default = false) {
internal static bool ToBoolean(this string input, bool @default = false) {
if (String.IsNullOrEmpty(input))
return @default;

Expand All @@ -90,14 +90,14 @@ public static bool ToBoolean(this string input, bool @default = false) {
return @default;
}

public static string ToHex(this IEnumerable<byte> bytes) {
internal static string ToHex(this IEnumerable<byte> bytes) {
var sb = new StringBuilder();
foreach (byte b in bytes)
sb.Append(b.ToString("x2"));
return sb.ToString();
}

public static bool IsValidIdentifier(this string value) {
internal static bool IsValidIdentifier(this string value) {
if (value == null)
return false;

Expand Down