Skip to content

Reduce DefaultSubmissionClient allocations#254

Merged
ejsmith merged 3 commits intoexceptionless:masterfrom
benaadams:DefaultSubmissionClient
Apr 18, 2021
Merged

Reduce DefaultSubmissionClient allocations#254
ejsmith merged 3 commits intoexceptionless:masterfrom
benaadams:DefaultSubmissionClient

Conversation

@benaadams
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Member

@ejsmith ejsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I really like the change of using interpolated strings. It's a much cleaner syntax so I'm glad they are going improve the perf. There used to be a lot of debate on when to do string concat vs stringbuilder vs string interpolation. It will be good to just say always use string interpolation.

@ejsmith ejsmith merged commit 118b006 into exceptionless:master Apr 18, 2021
@benaadams benaadams deleted the DefaultSubmissionClient branch April 18, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants