Skip to content

Breaking change - System.Diagnostics.ExceptionExtensions now marked as internal #285

@Jaans

Description

@Jaans

Hi Guys!

Thanks for the hard work and the latest updates. Really appreciate the quality and ease of use!

Ran into the breaking change from #266 where the System.Diagnostics.ExceptionExtensions has been internalized. I understand the desire to do this and have no issue with it.

What I wanted to get some feedback on is the recommended path for our scenario.
Some time ago, we used to have a dependency on Demystifier (@benaadams) but then saw that this was duplicated in Exceptionless and removed our dependency and used the .Demystify() method from the above mentioned internalized extensions class.

We still want to use .Demystify() E.g. for UI/Integration based exception messages which may or may not have a corresponding call to Exceptionless to "log it". It seems that Exceptionless has the demystifier implementation internally added and not as an external dependency on the Demystifier NuGet package - does that mean we have take a dependency on that NuGet package ourselves despite an implementation available within Exceptionless? (We have 463 projects using it so not a trivial decision for us).

Also, just to confirm, does Exceptionless apply the demystification logic implicitly for all exceptions sent (and that we don't have to do it before logging anymore) ?

Thanks again, Jaans.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions