Skip to content

Refactor Node interface #1896

Description

@tzdybal

Node interface is very cometbft centric. Apart from life-cycle methods it defines only one method - GetClient which returns cometbft RPC client implementation for given node type.

As rollkit won't expose cometbft client directly, we can reduce the interface to life-cycle methods which makes it kind of redundant (it will be almost equivalent to plain Service).

We need to rethink the Node abstraction, as we might want to expose some functionality of node (via RPC for go-execution implementations, or via go-interface for testing).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions