Skip to content

Extract error as const #1792

Closed
#1793
Closed
Extract error as const#1792
#1793
Labels
T:code-hygieneGeneral cleanup and restructuring of code to provide clarity, flexibility, and modularity.good first issueGood for newcomers

Description

@Manav-Aggarwal
Manav-Aggarwal
opened on Aug 9, 2024

nitpick: I would extract "failed to save block responses" as const.

Originally posted by @tzdybal in #1782 (comment)

nitpick: Similarly to other comment, this is quite fragile - we should have this value as const somewhere or make a bit less-specific assertion.

Originally posted by @tzdybal in #1782 (comment)

Activity

  1. github-project-automation
    added this to Evolveon Aug 9, 2024
  2. Manav-Aggarwal
    added
    good first issueGood for newcomers
    T:code-hygieneGeneral cleanup and restructuring of code to provide clarity, flexibility, and modularity.
    on Aug 9, 2024
  3. github-merge-queue
    added a commit that references this issue on Sep 24, 2024

    chore(manager): extract some errors as variables (#1793)

    4651836
  4. tzdybal
    closed this as completedin #1793on Sep 24, 2024
  5. github-project-automation
    moved this to Done in Evolveon Sep 24, 2024
  6. tac0turtle
    removed this from Evolveon Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T:code-hygieneGeneral cleanup and restructuring of code to provide clarity, flexibility, and modularity.good first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions