Skip to content

[WebGL] Remove surplus argument in glDrawElements. NFC - #27793

Merged
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:fix-webgl-postdraw
Sep 29, 2026
Merged

sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:fix-webgl-postdraw

Conversation

@sbc100

@sbc100 sbc100 commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

GL.postDrawHandleClientVertexAttribBindings takes no arguments, but glDrawElements was passing count to it.

It looks like this error has always been there since this function was first added in a0a5e19.

`GL.postDrawHandleClientVertexAttribBindings` takes no arguments, but
`glDrawElements` was passing `count` to it.

It looks like this error has always been there since this function
was first added in a0a5e19.
@sbc100
sbc100 requested review from dschuff and kripken September 28, 2026 23:03
@sbc100 sbc100 changed the title [WebGL] Remove surplus argument in glDrawElements [WebGL] Remove surplus argument in glDrawElements. NFC Sep 29, 2026
@sbc100
sbc100 enabled auto-merge (squash) September 29, 2026 00:26
@sbc100
sbc100 merged commit 81cdc6d into emscripten-core:main Sep 29, 2026
42 checks passed
@sbc100
sbc100 deleted the fix-webgl-postdraw branch September 29, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants