Skip to content

replaces then-redis with redis. closes #74#76

Merged
lukemelia merged 1 commit intoember-cli-deploy:masterfrom
maprules1000:master
Apr 30, 2017
Merged

replaces then-redis with redis. closes #74#76
lukemelia merged 1 commit intoember-cli-deploy:masterfrom
maprules1000:master

Conversation

@maprules1000
Copy link
Copy Markdown
Contributor

What Changed & Why

Replaces then-redis with node_redis since then-redis is no longer maintained and node_redis now contains promises

Related issues

Issue #51 - Swap out then-redis for another redis lib

PR Checklist

  • Add tests (would tests need to be added?)

@lukemelia
Copy link
Copy Markdown
Contributor

@maprules1000 are the APIs we were using in then-redis supported verbatim in redis?

@maprules1000
Copy link
Copy Markdown
Contributor Author

i'm almost certain. then-redis supported all redis commands.

@lukemelia lukemelia merged commit 2f57694 into ember-cli-deploy:master Apr 30, 2017
@ghedamat
Copy link
Copy Markdown
Contributor

well that was easy! :D thanks @maprules1000 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants