Fixing compiler warnings and typo#1159
Merged
Merged
Conversation
thbar
approved these changes
Jul 20, 2026
| when op in [:first, :last, :sum, :min, :max, :product], | ||
| do: series.dtype | ||
|
|
||
| defp dtype_for_agg_operation(op, _) when op in [:all?, :any?], do: :boolean |
Comment on lines
-1080
to
-1086
| @impl true | ||
| def size(series) do | ||
| data = new(:size, [lazy_series!(series)], {:u, 32}) | ||
|
|
||
| Backend.Series.new(data, {:u, 32}) | ||
| end | ||
|
|
| end | ||
|
|
||
| for {op, arity} <- @all_expressions do | ||
| for {op, arity} <- @all_expressions -- @first_only_expressions do |
Contributor
There was a problem hiding this comment.
Dead code too, because line 280 already defines the relevant code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.