Add support for M9g and M9gd (Graviton5) instance types - #8769
Closed
moko-poi wants to merge 1 commit into
Closed
Conversation
Regenerate the EC2 instance type metadata via the ec2geninfo tool to pick up the newly GA'd M9g and M9gd instances (AWS Graviton5). Both families are correctly classified as arm64; m9gd is marked as having instance storage. Resolves eksctl-io#8622
|
Would be great to have this reviewed, m9g is now GA and I'd love to provision these via the managed node groups. |
Contributor
|
#8723 address here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AWS recently announced the general availability of the M9g and M9gd general-purpose instance families, powered by Graviton5 (arm64) processors (announcement).
This PR regenerates the EC2 instance type metadata in
pkg/utils/instance/instance_types.govia theec2geninfotool (make update-ec2-info) so that eksctl recognizes the new instances.Notes:
m9g.*andm9gd.*, frommediumthrough48xlarge) are correctly classified asCPUArch: "arm64", so the appropriate arm64 AMI is selected automatically. No logic changes were required — architecture and AMI-type selection are driven entirely by this generated map.m9gd.*variants (with local NVMe SSD) are correctly markedInstanceStorageSupported: true.make update-ec2-inforefreshes the full instance list from the EC2DescribeInstanceTypesAPI, the diff also picks up other families AWS has added since the last regeneration (e.g.r8i,m8id,p6-b200). This is the expected behaviour of the generator.Verification:
go build ./pkg/utils/instance/...— passesgo test ./pkg/utils/instance/...— passesgofmt— cleanResolves #8622
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)