Skip to content

Change node role policy ReadOnly -> PullOnly (support ECR pull-through cache) - #8386

Merged
naclonts merged 1 commit into
eksctl-io:mainfrom
artem-nefedov:pullonly-node-policy
Jun 6, 2025
Merged

naclonts merged 1 commit into
eksctl-io:mainfrom
artem-nefedov:pullonly-node-policy

Conversation

@artem-nefedov

@artem-nefedov artem-nefedov commented May 23, 2025 •

Copy link
Copy Markdown
Contributor

Description

Change for default node IAM permissions to support ECR pull-through cache repositories,
remove extra unnecessary permissions, and be in line with current AWS guidelines.

Tested to work with AL2023 and Botterocket managed nodes.

Fixes #8318

Similar change in Karpenter (already merged): aws/karpenter-provider-aws#7963

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@naclonts naclonts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the submission 🔒

@naclonts
naclonts merged commit ec4e7fb into eksctl-io:main Jun 6, 2025
yehielnetapp pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Jun 9, 2025
…h cache) (eksctl-io#8386)

Change for default node IAM permissions to support ECR pull-through cache repositories, remove extra unnecessary permissions, and be in line with current AWS guidelines. Fixes issue eksctl-io#8318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support ECR pull-through cache repos by default

2 participants