Filter out known hop-by-hop response headers#151
Open
louis-cl wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix hop-by-hop response header forwarding
The proxy filtered standard hop-by-hop headers on requests, but normal HTTP responses copied backend headers through without filtering.
We discovered this while proxying an http2 connection client to http1 origin, which returned
Connection: closeand the http codec failed on client response because the proxy was copying theConnectionheader.Note that this change isn't addressing the
Connectionheader parsing to detect other headers to filter, per rfc 2616 section 14.10.