Skip to content

Add unified diff resolution events - #3064

Open
tobiasmelcher wants to merge 1 commit into
eclipse-platform:masterfrom
tobiasmelcher:d031119/unified-diff-events
Open

tobiasmelcher wants to merge 1 commit into
eclipse-platform:masterfrom
tobiasmelcher:d031119/unified-diff-events

Conversation

@tobiasmelcher

@tobiasmelcher tobiasmelcher commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Add optional unified-diff resolution events. Individual resolutions report one hunk, while bulk toolbar actions report one event containing all resolved hunks and the executed action. Keep manual resolution lifecycle cleanup consistent, avoid reporting presentation cleanup while opening a two-way compare, and refresh remaining code minings after delayed hunk replacement.

Expose resolution events from the unified-diff builder and report accepted, rejected, and manually deleted hunks. Keep lifecycle cleanup consistent for manual changes and suppress events for two-way compare navigation cleanup.

Handle undo at ABOUT_TO_UNDO and refresh remaining code minings after delayed replacements. Add coverage for event delivery, manual hunk resolution, undo timing, listener reentrancy, and code-mining positioning.
@tobiasmelcher
tobiasmelcher force-pushed the d031119/unified-diff-events branch from 4fdea17 to 17e97e1 Compare November 10, 2026 14:33
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ± 0      54 suites  ±0   35m 42s ⏱️ + 1m 34s
 5 014 tests + 9   4 992 ✅ + 9   22 💤 ±0  0 ❌ ±0 
12 933 runs  +27  12 779 ✅ +27  154 💤 ±0  0 ❌ ±0 

Results for commit 17e97e1. ± Comparison against base commit 5cccf6a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant