Repository navigation
fix(tcpfirewall): bound pre-route HTTP and TLS classification - #3809
Open
FrankWuwuwu wants to merge 2 commits into
Open
FrankWuwuwu wants to merge 2 commits into
FrankWuwuwu wants to merge 2 commits into
Conversation
FrankWuwuwu
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
November 9, 2026 18:37
|
We require contributors to sign our Contributor License Agreement, and we don't have @FrankWuwuwu on file. You can sign our CLA at https://e2b.dev/docs/cla . Once you've signed, post a comment here that says '@cla-bot check' |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Issue #3681 documented that incomplete HTTP headers can occupy orchestrator file descriptors and goroutines before
HandleConnreaches the existing per-sandbox connection limiter. The same ordering applies to TLS SNI parsing. This change bounds that pre-route stage without changing egress policy decisions or normal proxying.Validation
go test ./pkg/tcpfirewall -run '^(TestClassificationAdmission|TestSlowHTTPClassification|TestIsTransientAcceptError)' -count=1go test -race ./pkg/tcpfirewall -run '^(TestClassificationAdmission|TestSlowHTTPClassification)' -count=1go vet ./pkg/tcpfirewallThe tests cover per-sandbox budget isolation, one-time slot release, timeout rejection through tcpproxy routing, and a complete HTTP request that proceeds after the slow connection. The change does not claim to establish a production DoS threshold or solve accounting for other shared host services discussed in #3681.