Repository navigation
Throw the execution error when a streamed query fails early - #954
Merged
staticlibs merged 1 commit intoNov 3, 2026
Merged
Conversation
complete_query_streaming checked HasError() only inside the loop, but EXECUTION_ERROR is observable, so a failed query left the loop and was returned as a stream. The next JNI call then threw "Invalid result set" instead of the stored error. Fixes: duckdb#953
staticlibs
approved these changes
Nov 3, 2026
staticlibs
left a comment
staticlibs
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! It looks good to me, I will publish a snapshot with this change shortly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
jdbc_stream_results=true, a query that failed before its first chunk was ready reportedInvalid result setinstead of its own error.complete_query_streamingcheckedHasError()inside the loop, butEXECUTION_ERRORends the loop, so the failed stream was returned. The check now runs after the loop, likePendingQueryResult::ExecuteInternaldid in 1.x.Fixes #953