Repository navigation
Model class should use prototype rather than assigning new methods to each model in the constructor. #773
Description
Activity
It's the same for other classes too, like AggregateFunctions etc. In fact the only place this code is using
prototypeis in the drivers. 👎Probably has something todo with the fact we're using getters and setters.
Perhaps when this package was originally written JS didn't allow getters/setters on prototypes? Not sure.Would be interested to see if it's possible to change it. Feel free to submit some code.
Even if that were the case it's still a terrible reason for making every non-property instantiated in the constructor. This is some of the worst performing code I've used in ages, it was a massive mistake for my previous client to use it. No one should use orm2.
Using prototype has a number of advantages, but mostly the current method being used to populate methods per instance is very bad for performance and memory usage.