Include parameter name in ArgumentNullException for SDK version types#186
Merged
Conversation
Add nameof(version) to all ArgumentNullException throws in AppleSdkVersion, IPhoneSdkVersion, and MacOSXSdkVersion constructors for better diagnostics. The int[] overload in AppleSdkVersion already did this correctly; this makes the other constructors consistent. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves diagnostics in the Xamarin.MacDev Apple SDK version structs by ensuring ArgumentNullException consistently includes the offending parameter name in constructor null checks.
Changes:
- Add
nameof (version)toArgumentNullExceptionthrows inAppleSdkVersion (Version). - Add
nameof (version)toArgumentNullExceptionthrows inIPhoneSdkVersion (Version)andIPhoneSdkVersion (params int[]). - Add
nameof (version)toArgumentNullExceptionthrows inMacOSXSdkVersion (params int[])andMacOSXSdkVersion (Version).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Xamarin.MacDev/AppleSdkVersion.cs | Adds parameter name to ArgumentNullException for the Version constructor overload. |
| Xamarin.MacDev/IPhoneSdkVersion.cs | Adds parameter name to ArgumentNullException for Version and int[] constructor overloads. |
| Xamarin.MacDev/MacOSXSdkVersion.cs | Adds parameter name to ArgumentNullException for Version and int[] constructor overloads. |
rolfbjarne
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
nameof(version)to allArgumentNullExceptionthrows inAppleSdkVersion,IPhoneSdkVersion, andMacOSXSdkVersionconstructors for better diagnostics.The
int[]overload inAppleSdkVersionalready included this correctly; this makes all other constructors consistent.