Guard against setting empty XCODE_DEVELOPER_DIR_PATH env var#185
Open
rmarinho wants to merge 2 commits into
Open
Guard against setting empty XCODE_DEVELOPER_DIR_PATH env var#185rmarinho wants to merge 2 commits into
rmarinho wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR defensively avoids setting XCODE_DEVELOPER_DIR_PATH when AppleSdkSettings.Init() resolves an empty developer root, preventing downstream tools from treating an empty environment variable as an intentional configured value.
Changes:
- Adds a null/empty guard before setting
XCODE_DEVELOPER_DIR_PATH.
Only set the XCODE_DEVELOPER_DIR_PATH environment variable when DeveloperRoot is non-empty. If it is empty (defensive case), explicitly clear the env var to avoid leaving a stale value from a prior Init() call. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rmarinho
force-pushed
the
fix/sdksettings-empty-env-var
branch
from
9179f25 to
83a5f40
Compare
rolfbjarne
requested changes
Jun 1, 2026
The foundSdk guard already ensures DeveloperRoot is non-null/empty, making the defensive check redundant. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a null/empty check before setting the
XCODE_DEVELOPER_DIR_PATHenvironment variable inAppleSdkSettings.Init(). Setting an empty string is different from not setting the variable and could confuse downstream tools that check for its presence.Context
While
DeveloperRootis expected to be non-empty at this point (sincefoundSdkis true), this defensive guard prevents unexpected behavior if validation logic changes in the future.