Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
✅ No release notes required |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
⚠️ Affects-Design-Time
This comment has been minimized.
This comment has been minimized.
Remove the compiler XML parser, task changes, diagnostic and added fixture. Reuse GenerateILLinkSubstitutions at PrepareForILLink and pass its output as trimmer substitutions. Preserve standalone compilation and user resources without changing compiler code. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
T-Gro
changed the title
Contributor
|
🔍 Tooling Safety Check — Affects-Build-Infra, Affects-Compiler-Output, Affects-Test-Tooling
|
Keep descriptor generation and trimmer arguments together, remove unnecessary XML quote escaping, and explain the separate input needed when the opt-out changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run fsharp-ci |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old target generated XML after MSBuild had collected embedded resources. The file existed in
obj, but fsc never received a--resourceargument for it. Moving generation earlier introduced duplicateILLink.Substitutions.xmlresources with standalone builds and user descriptors.This changes who consumes the file: the existing task generates the rules during publish, and
ILLink --substitutions file.xmlreads them directly. Nothing new is embedded. The compiler, task implementation, FSharp.Core descriptor, and user descriptors are unchanged.The cache records the opt-out value so changing it reruns trimming instead of reusing an already-stripped output. An unchanged publish still skips compilation and trimming.
Scope: ordinary app/library assemblies published from an F# project with
PublishTrimmed. Metadata copied by explicit--staticlink, C#-hosted publishing, and NativeAOT remain unchanged.