Checker: do not copy inferred file signature - #20524
Open
auduchinok wants to merge 4 commits into
Open
Conversation
…ure file Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
Warning No PR link found in some release notes, please consider adding it.
|
Contributor
|
🔍 Tooling Safety Check — Affects-Design-Time
|
T-Gro
reviewed
Sep 11, 2026
T-Gro
left a comment
Member
There was a problem hiding this comment.
🤖 🕵️ AI review — verify independently.
| FSharpAssemblySignature(g, thisCcu, ccuSigForFile, tcImports, None, ccuSigForFile) | ||
|
|
||
| member _.FileSignature = | ||
| FSharpAssemblySignature(g, thisCcu, ownSigForFile, tcImports, None, ownSigForFile) |
Member
There was a problem hiding this comment.
🤖 🕵️ FileSignature loses the declaring entity of nested types from earlier files; PartialAssemblySignature returns the correct parent.
// First.fs
module First
module Nested =
type R = { Value: int }
// Second.fs
module Second
let r: First.Nested.R = { Value = 1 }
// After checking Second.fs:
let owner =
results.FileSignature.FindEntityByPath ["Second"]
|> Option.get
|> fun e -> e.MembersFunctionsAndValues
|> Seq.find (fun v -> v.DisplayName = "r")
|> fun v -> v.FullType.TypeDefinition.DeclaringEntity
|> Option.map (fun e -> e.FullName)
// None; expected Some "First.Nested"
T-Gro
self-requested a review
September 11, 2026 15:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #20478.
Removes extra copying of inferred signature which prevents extra work and reuses the symbols from the analysis in the signature.