Skip to content

Update source2.vb#48074

Merged
BillWagner merged 3 commits intodotnet:mainfrom
dmitrymatin:VB-threads-shared-method
Aug 26, 2025
Merged

Update source2.vb#48074
BillWagner merged 3 commits intodotnet:mainfrom
dmitrymatin:VB-threads-shared-method

Conversation

@dmitrymatin
Copy link
Copy Markdown
Contributor

Summary

Fix shared method references in the comments

@dmitrymatin dmitrymatin requested review from a team and BillWagner as code owners August 23, 2025 00:10
@dotnetrepoman dotnetrepoman bot added this to the August 2025 milestone Aug 23, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Aug 23, 2025
@BillWagner
Copy link
Copy Markdown
Member

Hi @dmitrymatin

Can you add a VBPROJ file in this folder so our CI build validates your changes? Thank you.

@dmitrymatin
Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@dmitrymatin
Copy link
Copy Markdown
Contributor Author

Good morning @BillWagner

Thanks, I have added the VBPROJ file now. If anything else is needed, please let me know.

@BillWagner
Copy link
Copy Markdown
Member

Thanks for adding the project file @dmitrymatin

Now, we have a couple CI build issues to address. It looks like all the build issues are duplicate type names. I'd recommend fixing those by either changing the names, or introducing namespaces to resolve the conflict, whichever is easier.

In the meantime, I did review your source changes, and they are fine, I'll approve and merge this as soon as we get a clean build.

Thanks again for helping us improve.

@dmitrymatin
Copy link
Copy Markdown
Contributor Author

Thanks @BillWagner

I have addressed the build issues by changing the names in source4.vb: (ThreadWithState to ThreadWithState2 and Example to Example2) as this would be in line with the corresponding C# snippets for this article (file source4.cs)

I also deleted an empty comment line in source4.vb

Thank you again, I'm very happy to be involved!

Copy link
Copy Markdown
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @dmitrymatin

This looks great, and I'll :shipit: now.

You should see the changes on our live site in the next day or two, on our regular publishing cycle. Thanks again for contributing to docs! 🎆

@BillWagner BillWagner merged commit 3ef9fab into dotnet:main Aug 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants