Conversation
|
Hi @dmitrymatin Can you add a VBPROJ file in this folder so our CI build validates your changes? Thank you. |
|
@dotnet-policy-service agree |
|
Good morning @BillWagner Thanks, I have added the VBPROJ file now. If anything else is needed, please let me know. |
|
Thanks for adding the project file @dmitrymatin Now, we have a couple CI build issues to address. It looks like all the build issues are duplicate type names. I'd recommend fixing those by either changing the names, or introducing namespaces to resolve the conflict, whichever is easier. In the meantime, I did review your source changes, and they are fine, I'll approve and merge this as soon as we get a clean build. Thanks again for helping us improve. |
|
Thanks @BillWagner I have addressed the build issues by changing the names in source4.vb: ( I also deleted an empty comment line in source4.vb Thank you again, I'm very happy to be involved! |
BillWagner
left a comment
There was a problem hiding this comment.
Thanks again @dmitrymatin
This looks great, and I'll
now.
You should see the changes on our live site in the next day or two, on our regular publishing cycle. Thanks again for contributing to docs! 🎆
Summary
Fix shared method references in the comments