feat: support tiny-skia CPU backend#23
Merged
Merged
Conversation
Owner
donkeyteethUX
left a comment
There was a problem hiding this comment.
Thanks for taking this on!
It looks good. All the examples I tried worked fine with tiny-skia except for huge_scatter (which is not surprising). Just a few small requests.
Contributor
Author
|
Thank you for reviewing! I have made revisions based on your suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I introduce
PlotRenderStrategyto switch between the existing shader path and a new canvas-based path for CPUrenderers like
tiny-skia. The strategy can be configured manually or auto-detected from the active iced graphicsbackend. The shared plot update/draw implementation is reused by both shader and canvas programs, and CPU picking is used when rendering through canvas.
I also add
examples/auto_backend.rs, which auto-detects the render strategy, displays the current strategy, andprovides x/y layout offset sliders for testing
PlotWidgetbehavior under different backends.Known issue
When running with:
ICED_BACKEND="tiny-skia" cargo run --example auto_backendPlotWidget may show corrupted canvas content after applying layout offsets. This is an iced 0.14 tiny-skia/canvas
issue, not a PlotWidget rendering bug.
The issue is already fixed in iced 0.15.0-dev, which can be verified here:
https://github.com/zao111222333/iced_plot/tree/iced-0.15.0-dev
That branch only upgrades iced, and the offset corruption disappears.