Skip to content

ENGDOCS-2152 - #20378

Merged
aevesdocker merged 1 commit into
docker:mainfrom
aevesdocker:ENGDOCS-2152
Jul 11, 2024
Merged

aevesdocker merged 1 commit into
docker:mainfrom
aevesdocker:ENGDOCS-2152

Conversation

@aevesdocker

@aevesdocker aevesdocker commented Jul 8, 2024 •

Copy link
Copy Markdown
Contributor

Description

Edits example to correct for the fact the alpine image does not come with the useradd command. Closes #20063

Also makes it clear the deploy specification is not just for Docker Swarm. Closes #20116

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions Bot added the area/compose Relates to docker-compose.yml spec or docker-compose binary label Jul 8, 2024
@netlify

netlify Bot commented Jul 8, 2024 •

Copy link
Copy Markdown

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 3e6daa2
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/668bc0fa23116800089c7b93
😎 Deploy Preview https://deploy-preview-20378--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jhrotko jhrotko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to add the suggestion or not

Comment thread content/includes/compose/deploy.md Resolved
@aevesdocker
aevesdocker marked this pull request as ready for review July 11, 2024 12:34
@aevesdocker
aevesdocker requested a review from a team July 11, 2024 12:34
@aevesdocker aevesdocker added the status/review Pull requests that are ready for review label Jul 11, 2024
@usha-mandya

Copy link
Copy Markdown
Member

The flaky test issue was fixed in #20377

@aevesdocker
aevesdocker merged commit a48d866 into docker:main Jul 11, 2024
elegantcoder pushed a commit to elegantcoder/docs that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/compose Relates to docker-compose.yml spec or docker-compose binary status/review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deploy:resources:limits section works also without using Docker Swarm Errors in docs: compose/file-watch example

3 participants