test: attached up must exit on external stop of a restarting container - #14023
Open
ndeloof wants to merge 1 commit into
Open
test: attached up must exit on external stop of a restarting container#14023ndeloof wants to merge 1 commit into
ndeloof wants to merge 1 commit into
Conversation
ndeloof
force-pushed
the
e2e-up-exit-restart-backoff
branch
2 times, most recently
from
August 11, 2026 11:43
7fcb37b to
8297cb0
Compare
Regression tests for #13985: a container stopped while in restart backoff emits no die event, and since v2.39.3 the attached up waits forever for a die event that never comes. Two explicit scenarios: - external stop alone: containers are stopped but not removed (stop event, no destroy). Up to v2.39.2 the attached up exited a few seconds after the stop. - external stop+down: the container in backoff emits stop then destroy. Both tests fail on main and pass with the monitor fix from #13990. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
e2e-up-exit-restart-backoff
branch
from
August 13, 2026 11:48
8297cb0 to
4553777
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
E2E regression tests for #13985: a container stopped while in restart backoff emits no
dieevent, and since v2.39.3 an attachedupwaits forever for adiethat never comes.Two explicit scenarios, sharing a helper (attached
upon a crash-looping service, wait for restart backoff, external command from another process, assertupexits within 30s):stopalone — containers stopped but not removed (stopevent, nodestroy). Up to v2.39.2 the attachedupexited a few seconds after the stop, so this is part of the regression, not just thedowncase.stop+down— the literal repro from the issue (stopthendestroyevents).Verified locally: both fail on
main, both pass with #13990. Thestop-alone test also fails with the destroy-only approach from #13988, which is why #13990 is preferred. Expected to stay red until #13990 merges — intended to be merged alongside/after it.🤖 Generated with Claude Code