man: remove tools.go in favor of tools directive#7041
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR modernizes the Docker CLI's tool dependency management by replacing the legacy //go:build tools blank-import pattern (man/tools.go) with Go 1.25's native tool directive in vendor.mod.
Changes reviewed:
man/tools.go— deleted: the old//go:build tools/ blank-import file forgo-md2man/v2is superseded by thetooldirective on Go ≥ 1.21 (and fully supported in 1.25).vendor.mod—github.com/cpuguy83/go-md2man/v2added to a groupedtool (...)block and moved from the directrequiresection to// indirect(correct: the// indirectannotation for tool-only dependencies is the expected Go modules behaviour when no production code imports the package).
No issues found. The grouped tool (...) syntax is valid in Go 1.25, the // indirect marking is semantically correct for tool-only deps, and go mod vendor will continue to vendor the tool sources via the directive. Removal of the man/tools.go file is safe given the project requires Go 1.25+.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vvoland
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)