Fixes #2753 - add case-insensitive auth

cli/command/image/push.go

@@ -69,7 +69,8 @@ func RunPush(dockerCli command.Cli, opts pushOptions) error {
 	ctx := context.Background()
 
 	// Resolve the Auth config relevant for this server
-	authConfig := command.ResolveAuthConfig(ctx, dockerCli, repoInfo.Index)
+	authConfig := AuthResolver(dockerCli)(ctx, repoInfo.Index)
+
 	encodedAuth, err := command.EncodeAuthToBase64(authConfig)
 	if err != nil {
 		return err

cli/command/image/trust.go

@@ -8,6 +8,7 @@ import (
 	"io"
 	"io/ioutil"
 	"sort"
+	"strings"
 
 	"github.com/docker/cli/cli/command"
 	"github.com/docker/cli/cli/streams"
@@ -344,6 +345,8 @@ func TagTrusted(ctx context.Context, cli command.Cli, trustedRef reference.Canon
 // AuthResolver returns an auth resolver function from a command.Cli
 func AuthResolver(cli command.Cli) func(ctx context.Context, index *registrytypes.IndexInfo) types.AuthConfig {
 	return func(ctx context.Context, index *registrytypes.IndexInfo) types.AuthConfig {
+		index.Name = strings.ToLower(index.Name)
+
 		return command.ResolveAuthConfig(ctx, cli, index)
 	}
 }

cli/command/registry/login.go

@@ -106,7 +106,7 @@ func runLogin(dockerCli command.Cli, opts loginOptions) error { //nolint: gocycl
 		authServer    = command.ElectAuthServer(ctx, dockerCli)
 	)
 	if opts.serverAddress != "" && opts.serverAddress != registry.DefaultNamespace {
-		serverAddress = opts.serverAddress
+		serverAddress = strings.ToLower(opts.serverAddress)
 	} else {
 		serverAddress = authServer
 	}

cli/command/registry/logout.go

@@ -3,6 +3,7 @@ package registry
 import (
 	"context"
 	"fmt"
+	"strings"
 
 	"github.com/docker/cli/cli"
 	"github.com/docker/cli/cli/command"
@@ -43,9 +44,13 @@ func runLogout(dockerCli command.Cli, serverAddress string) error {
 		hostnameAddress = serverAddress
 	)
 	if !isDefaultRegistry {
-		hostnameAddress = registry.ConvertToHostname(serverAddress)
+		hostnameAddress = registry.ConvertToHostname(strings.ToLower(serverAddress))
+
+		// Appending not lowercased version for backward compatibility where user had
+		// saved the registry with an uppercase letters.
+		regsToLogout = append(regsToLogout, registry.ConvertToHostname(serverAddress))
 		// the tries below are kept for backward compatibility where a user could have
-		// saved the registry in one of the following format.
+		// saved the registry in one of the following formats.
 		regsToLogout = append(regsToLogout, hostnameAddress, "http://"+hostnameAddress, "https://"+hostnameAddress)
 	}