Repository navigation
Conversation
sbillinge
reviewed
Aug 8, 2024
sbillinge
left a comment
sbillinge
left a comment
Contributor
There was a problem hiding this comment.
this looks good. Did that license come with cookiecutter? We need to change that to BSD 3-clause if not.
| @@ -0,0 +1,41 @@ | |||
| This program is part of the DiffPy and DANSE open-source projects | |||
Contributor
There was a problem hiding this comment.
This one should be the BSD-3clause. We own copyright so we don't want the old license.
Contributor
Author
There was a problem hiding this comment.
I copied over the old license from this package, but we want to replace it with the cookiecutter license?
Contributor
There was a problem hiding this comment.
Normally no, but in this case yes.... 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new files from the cookiecutter.