You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This should be OK if incorporating its functionality into init, that is the only call to _clear().
I had originally made this a public member so classes in other modules that had a DataClusters member could use it when they cleared their members. However, in the existing implementation all instances of DataClusters are local variables that are created when needed and drop out of scope when not, so that functionality never came up.
Thanks @Ainamacar . We normally try and keep the the code simple so let's leave this as an open issue. It is not high priority. Just general code hygiene that we note down when we find it and clean up from time to time.
Activity
sbillinge commentedon Aug 13, 2024
It should not be needed but make sure the behavior doesn't change when we do that
Ainamacar commentedon Aug 14, 2024
This should be OK if incorporating its functionality into init, that is the only call to _clear().
I had originally made this a public member so classes in other modules that had a DataClusters member could use it when they cleared their members. However, in the existing implementation all instances of DataClusters are local variables that are created when needed and drop out of scope when not, so that functionality never came up.
sbillinge commentedon Aug 14, 2024
Thanks @Ainamacar . We normally try and keep the the code simple so let's leave this as an open issue. It is not high priority. Just general code hygiene that we note down when we find it and clean up from time to time.