Repository navigation
Properly source feature options - #149
Merged
Merged
Conversation
Christof Marti (chrmarti)
requested changes
Aug 30, 2022
joshspicer
requested review from
Chuck Lantz (Chuxel) and
Christof Marti (chrmarti)
August 30, 2022 20:37
joshspicer
enabled auto-merge (squash)
August 30, 2022 20:42
Christof Marti (chrmarti)
approved these changes
Aug 31, 2022
Christof Marti (chrmarti)
left a comment
Christof Marti (chrmarti)
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148
Instead of trying to use
xargsto parse the .env file, directly source the .env file withset -aenabled.In the generated Dockerfile, this env file is simply sources with the
.operator (The most portable/POSIX-y way to source https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#dot)