Skip to content

Re-run plugin PR checks when main gains a new publication gateΒ #105

Description

@devantler

πŸ€– Generated by the Agentic Engineer

Body repaired 2026-09-05. The original body was the literal string @/tmp/agent-plugins-stale-checks-issue.md β€” a --body "@path" invocation posted the path instead of the file β€” so this issue carried no content for five weeks. Rewritten from the title and the repository's own history.

Evidence

ci.yaml has gained two publication gates since this repository's PR traffic began, each a job the aggregated CI - Required Checks gate depends on:

A pull-request workflow runs only on that PR's own pull_request events. Every PR already open when a gate lands therefore keeps the green CI - Required Checks result it earned before the gate existed; nothing re-evaluates it, and the branch-protection rule keyed on that check name is satisfied by the stale run. Such a PR can merge without the new gate ever having run against it β€” which is exactly the class of change (a version left unbumped, a synced skill hand-edited) the gate was added to stop.

Related but distinct, measured 2026-09-05: a PR opened in this repository (#194) received no pull_request run at all until it was closed and reopened. That is event delivery, not gate staleness, but it is the same blind spot β€” a PR whose green predates, or never included, the checks main requires.

Affected audience and impact

Every PR open at the moment a required gate is added β€” the daily deps/agent-skills-update PR most often, since it is open nearly every day. The impact is a merge that bypasses a gate main declares required, with no signal.

Expected behaviour

When a change to main adds or alters a required CI gate, every open PR is re-evaluated against it before it can merge β€” either by re-triggering each open PR's checks (an update-branch where the PR is behind, a dispatch of the CI workflow against the PR's head where it is not) from a workflow that runs on pushes to main touching .github/workflows/ci.yaml, or by making the required check's identity change whenever its job set changes, so a stale green no longer satisfies the rule.

Acceptance criteria

  • After a push to main that changes .github/workflows/ci.yaml, every open PR's required check is re-run at the PR's current head without a manual push.
  • A PR whose green predates a newly added gate cannot merge until that gate has run against its head β€” pinned by a fixture or a documented live check.
  • The mechanism is documented in AGENTS.md beside the description of the two gates, so a future gate addition is recognised as the moment this applies.

Rough size: S–M β€” one workflow (or one ruleset change) plus a test.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions