Skip to content

Add EnviousWispr's binaryTarget host to egress allowlist - #360

Open
saurabhav88 wants to merge 1 commit into
dependabot:mainfrom
saurabhav88:saurabhav88/allowlist-enviouswispr-models
Open

saurabhav88 wants to merge 1 commit into
dependabot:mainfrom
saurabhav88:saurabhav88/allowlist-enviouswispr-models

Conversation

@saurabhav88

Copy link
Copy Markdown

What are you trying to accomplish?

Add models.enviouswispr.com (exact) to ecosystem_default_domains.swift, so Swift update jobs can resolve a package whose public Package.swift declares a binaryTarget on that host.

Why. saurabhav88/EnviousWispr is a public macOS app. Its Package.swift declares one binary target on our own host:

https://models.enviouswispr.com/frameworks/cwebrtcaec/ew-4355.3/CWebRTCAEC.xcframework.zip

(a WebRTC AEC3 build, BSD-licensed, 373,343 bytes, with a SwiftPM checksum). Since egress enforcement, every Swift job in that repository fails in package resolution, so no Swift update PR can be opened or recreated:

proxy | [068] GET https://models.enviouswispr.com:443/frameworks/cwebrtcaec/ew-4355.3/CWebRTCAEC.xcframework.zip
proxy | [068] * egress not allowlisted models.enviouswispr.com
proxy | [068] 403 https://models.enviouswispr.com:443/frameworks/cwebrtcaec/ew-4355.3/CWebRTCAEC.xcframework.zip
error: failed downloading '...CWebRTCAEC.xcframework.zip' which is required by binary target 'CWebRTCAEC': badResponseStatusCode(403)

This is the same failure mode as the existing Swift entries (sdk.karte.io, prelude-public.s3.amazonaws.com, applesdk.vindral.com, csspeechstorage.blob.core.windows.net): an anonymous host serving an xcframework.zip binaryTarget declared in the owner's own public manifest. Any fork of the repository with Dependabot enabled hits the same block.

What the host is. A Cloudflare R2 public bucket behind a custom domain. Anonymous, read-only, no redirect. Besides this framework it serves the app's public ML model files (speech models that the shipped app downloads on first run). It holds no private or per-tenant content and has no upload path.

Anything you want to highlight for special attention from reviewers?

  • I tried the per-job route first, and it did not work. I declared the host under registries: in dependabot.yml (type: git, url: https://models.enviouswispr.com, no credential, as "Resolving a blocked host" says for anonymous hosts) and referenced it from the swift update (saurabhav88/EnviousWispr#4494). The next job's definition still carried only "credentials-metadata":[{"type":"git_source","host":"github.com"}], so the entry never reached the proxy and the request was blocked again. If a credential-less registry is meant to reach the job, that may be worth a look on its own; if there is a supported way to declare an anonymous download host for the swift ecosystem, I am happy to use that instead and close this.
  • Triage, stated plainly. The host name matches the requester, which your skill lists as a signal to look twice. It is the requester's own public artifact host, in the same position as the vendor SDK hosts above; it is not a registry, has no tenants and needs no authentication. This repository is an app, not an SDK that many projects depend on, so the benefit is to this repository and its forks. Your call whether that clears the bar for the defaults.
  • Exact form. enviouswispr.com and its other subdomains are the product website and are not needed. Child, sibling and parent probes are added so the entry cannot be widened quietly.

Evidence gathered with the skill's verify_host steps:

models.enviouswispr.com -> 104.21.57.150 172.67.146.167 2606:4700:3037::ac43:92a7 2606:4700:3030::6815:3996
status=200 next_hop=   (GET of the real artifact path, --max-redirs 0, 373343 bytes)
subject=CN=5b7c8de3.sni.cloudflaressl.com   issuer=C=US, O=Google Trust Services, CN=WE1

The certificate is Cloudflare's shared SNI certificate, so it does not by itself show ownership. Ownership evidence is the public manifest above, which pins this exact URL with a checksum.

How will you know you've accomplished your goal?

  • Positive probe for the real artifact URL in TestEgressAllowlist_PublicVendorRegistriesAllowed.
  • https://evil.models.enviouswispr.com/payload in childProbes of TestEgressAllowlist_NewEntriesDoNotWidenBeyondExactHosts, plus child, sibling (attacker.enviouswispr.com) and parent (enviouswispr.com) probes in the must-stay-blocked list of TestEgressAllowlist_PublicVendorRegistriesAllowed.
  • After release, @dependabot recreate on saurabhav88/EnviousWispr#4305 should resolve packages.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

The first two boxes are unticked on purpose: I could not run go test or script/test in my environment, so the added tests are unverified until CI runs them. The edits follow the existing entries line for line.

models.enviouswispr.com serves the CWebRTCAEC xcframework.zip binaryTarget
declared in the public Package.swift of saurabhav88/EnviousWispr. Swift
update jobs for that repository fail in package resolution with
"egress not allowlisted models.enviouswispr.com", so no Swift update PR
can be opened or recreated.

The host is an anonymous Cloudflare R2 public bucket with no redirect.
Exact form; child, sibling and parent probes keep the rest of
enviouswispr.com closed.
@saurabhav88
saurabhav88 requested a review from a team as a code owner November 11, 2026 11:29
@github-actions github-actions Bot added the allowlist Changes the default egress allowlist label Nov 11, 2026
saurabhav88 added a commit to saurabhav88/EnviousWispr that referenced this pull request Nov 11, 2026
…job (#4488) (#4497)

PR #4494 declared models.enviouswispr.com as a credential-less `registries`
entry so Dependabot's proxy would allow the CWebRTCAEC binaryTarget
download. The recreate job after that merge (run 43009745050) failed the
same way: its job definition still carried only the github.com git
credential, so the entry never reached the proxy.

The entry is removed. The comment now records why the Swift job is blocked,
that a credential-less registry does not help, and that the host was
requested for the proxy's default allowlist in dependabot/proxy#360. Until
that request is merged and released, Swift Dependabot updates stay blocked;
nothing else changes.

Part of #4488

Self-audit-grep: git grep -n -E "ew-binary-host|registries:|models\.enviouswispr\.com" -- .github
Self-audit-owner: .github/dependabot.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

allowlist Changes the default egress allowlist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant