Enrich code quality review suggestions#43
Conversation
2187a68 to
c4c6b49
Compare
Greptile SummaryThis PR strengthens the code-quality review contract.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The updated reviewer and orchestration instructions consistently define the richer Markdown contract, while the regression test verifies the required instructions using the repository's established documentation-testing approach. Important Files Changed
Reviews (1): Last reviewed commit: "enrich code quality review suggestions" | Re-trigger Greptile |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4c6b494bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
OpenCode PR Review: 1 inline finding
One actionable finding from the |
- code-quality-reviewer.md: only emit a `suggestion` block when the finding's own line is itself a head-side changed line, since the orchestrator may relocate an unanchorable finding to a nearby changed line. - review-pr.md: strip any `suggestion` block from a finding whose anchor was relocated, so GitHub never applies it to the wrong line. - validate-opencode.bats: assert the full three-paragraph message contract, the `|-` block scalar, the review-pr.md message template, and the new relocation guard in both files. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dceoy
left a comment
There was a problem hiding this comment.
Reviewed current head 7abb69d. One actionable contract inconsistency remains.
dceoy
left a comment
There was a problem hiding this comment.
Reviewed current head 2181125e1b54.
No actionable issues found. The rich Markdown contract is consistent between the code-quality reviewer and orchestrator, suggestion blocks are guarded against relocated anchors, the regression assertions cover the structural contract, and the latest CI run passes.
Summary
Testing
.agents/skills/local-qa/scripts/qa.shCloses #37