Skip to content

Enrich code quality review suggestions#43

Merged
dceoy merged 3 commits into
mainfrom
fix/rich-code-quality-comments
Jul 26, 2026
Merged

Enrich code quality review suggestions#43
dceoy merged 3 commits into
mainfrom
fix/rich-code-quality-comments

Conversation

@dceoy

@dceoy dceoy commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • require code-quality findings to explain the problem, practical impact, and concrete resolution
  • include GitHub suggested-change blocks when a safe single-line replacement is available
  • preserve multiline Markdown and fenced code in structured inline review comments
  • add a regression test for the richer finding contract

Testing

  • .agents/skills/local-qa/scripts/qa.sh

Closes #37

@dceoy dceoy self-assigned this Jul 26, 2026
@dceoy
dceoy force-pushed the fix/rich-code-quality-comments branch from 2187a68 to c4c6b49 Compare July 26, 2026 14:41
@dceoy
dceoy marked this pull request as ready for review July 26, 2026 14:43
@greptile-apps

greptile-apps Bot commented Jul 26, 2026

Copy link
Copy Markdown

Greptile Summary

This PR strengthens the code-quality review contract.

  • Requires findings to separately explain the defect, practical impact, and concrete resolution.
  • Adds guidance for safe GitHub suggested-change blocks and preserving multiline Markdown.
  • Adds regression assertions covering the enriched reviewer and orchestration instructions.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The updated reviewer and orchestration instructions consistently define the richer Markdown contract, while the regression test verifies the required instructions using the repository's established documentation-testing approach.

Important Files Changed

Filename Overview
.opencode/agents/code-quality-reviewer.md Defines richer actionable finding messages and limits suggested-change blocks to complete, safe replacements.
.opencode/commands/review-pr.md Instructs the orchestrator to preserve finding Markdown when constructing inline review comments.
tests/validate-opencode.bats Adds repository-conventional documentation assertions for the richer finding contract.

Reviews (1): Last reviewed commit: "enrich code quality review suggestions" | Re-trigger Greptile

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4c6b494bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .opencode/agents/code-quality-reviewer.md

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenCode PR Review: 1 inline finding(s).

Review completed.

Comment thread tests/validate-opencode.bats
@opencode-agent

Copy link
Copy Markdown
    The PR review has been successfully submitted and updated.

OpenCode PR Review: 1 inline finding

One actionable finding from the test-coverage-reviewer was posted inline at tests/validate-opencode.bats:103 noting that the new regression test only greps for prose substrings and does not validate the structural template changes (the |- YAML block scalar, the updated review-pr.md message template, and two of the three required paragraphs in code-quality-reviewer.md), leaving gaps that would allow structural regressions to pass undetected.

github run

- code-quality-reviewer.md: only emit a `suggestion` block when the finding's
  own line is itself a head-side changed line, since the orchestrator may
  relocate an unanchorable finding to a nearby changed line.
- review-pr.md: strip any `suggestion` block from a finding whose anchor was
  relocated, so GitHub never applies it to the wrong line.
- validate-opencode.bats: assert the full three-paragraph message contract,
  the `|-` block scalar, the review-pr.md message template, and the new
  relocation guard in both files.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

@dceoy dceoy left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head 7abb69d. One actionable contract inconsistency remains.

Comment thread .opencode/commands/review-pr.md

@dceoy dceoy left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head 2181125e1b54.

No actionable issues found. The rich Markdown contract is consistent between the code-quality reviewer and orchestrator, suggestion blocks are guarded against relocated anchors, the regression assertions cover the structural contract, and the latest CI run passes.

@dceoy
dceoy merged commit 7a06d3a into main Jul 26, 2026
11 checks passed
@dceoy
dceoy deleted the fix/rich-code-quality-comments branch July 26, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: code-quality-reviewer should give back

2 participants