Skip to content

fix(bootstrap): Creating dedicated thread pool for executing async bootstrap steps + misc fixes#5798

Merged
jjoyce0510 merged 11 commits intodatahub-project:masterfrom
jjoyce0510:jj--fix-async-bootstrap
Sep 1, 2022
Merged

fix(bootstrap): Creating dedicated thread pool for executing async bootstrap steps + misc fixes#5798
jjoyce0510 merged 11 commits intodatahub-project:masterfrom
jjoyce0510:jj--fix-async-bootstrap

Conversation

@jjoyce0510
Copy link
Copy Markdown
Collaborator

@jjoyce0510 jjoyce0510 commented Sep 1, 2022

Summary

In this PR, we create a dedicated thread pool that will help execute asynchronous bootstrap steps. This prevents the main spring thread from being blocked while async steps run, which causes a strange lag in the deployment experience.

We also fix misc bugs:

  • make the roles ingestion step asynchronous to ensure that roles are successfully ingestd on first boot.
  • refactor the default role privileges
  • fix NPE recently introduced into JavaEntityClient (sign up and reset password)

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@jjoyce0510 jjoyce0510 changed the title fix(bootstrap): Creating dedicated thread pool for executing async bootstrap steps fix(bootstrap): Creating dedicated thread pool for executing async bootstrap steps + misc fixes Sep 1, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 1, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ +2   8m 16s ⏱️ - 1m 30s
121 suites ±0       0 💤 ±0 
121 files   ±0       0  - 2 

Results for commit 8bf11e9. ± Comparison against base commit dbcd309.

Copy link
Copy Markdown
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjoyce0510 jjoyce0510 merged commit ca29f8b into datahub-project:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants