Skip to content

fix(ui): Improve Error Messaging on the UI#5752

Merged
jjoyce0510 merged 5 commits intodatahub-project:masterfrom
jjoyce0510:jj--log-better-errors
Aug 29, 2022
Merged

fix(ui): Improve Error Messaging on the UI#5752
jjoyce0510 merged 5 commits intodatahub-project:masterfrom
jjoyce0510:jj--log-better-errors

Conversation

@jjoyce0510
Copy link
Copy Markdown
Collaborator

@jjoyce0510 jjoyce0510 commented Aug 27, 2022

Summary

In this PR we vastly improve how errors are displayed on the frontend. We also fix minor UI bugs: hide recommendations on search boxes other than the primary boxes. Also fix errors on Analytics fetch when no usage events have been ingested yet.

Check screenshots below!

Screenshots
Screen Shot 2022-08-26 at 5 50 28 PM
Screen Shot 2022-08-26 at 5 51 10 PM
Screen Shot 2022-08-26 at 6 02 04 PM
Screen Shot 2022-08-26 at 6 08 29 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 27, 2022

Unit Test Results (build & test)

504 tests  ±0   504 ✔️ ±0   8m 33s ⏱️ -57s
117 suites ±0       0 💤 ±0 
117 files   ±0       0 ±0 

Results for commit 0f31d61. ± Comparison against base commit 06d29df9.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful!

@jjoyce0510 jjoyce0510 merged commit ea9b5f8 into datahub-project:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants