fix(ui) Refresh executions on Ingestion page when they are visible#5698
Merged
chriscollins3456 merged 1 commit intodatahub-project:masterfrom Aug 22, 2022
Merged
Conversation
aditya-radhakrishnan
approved these changes
Aug 22, 2022
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug that only occurs sometimes when we're unlucky where we don't fetch the executions list because the
lastRefreshtime did not change. This was happening becausenew Date().getMilliseconds()will return how many milliseconds into the second we are, not the total number of milliseconds since the epoch. That means that since we refresh exactly every 3 seconds, there's a real chance that occasionally this number is the same as the previouslastRefreshand we don't refresh the executions list. Fix this by settinglastRefreshas the number of milliseconds since the epoch so it's always new.I also noticed that we were refreshing every executions list from every source that was opened at any point, even if it is now closed. So I added a check to only refresh if the executions list is open.
Checklist