feat(ingestion-ui) Display CLI-based ingestion sources in UI#5681
Merged
jjoyce0510 merged 4 commits intodatahub-project:masterfrom Aug 19, 2022
Merged
Conversation
Contributor
jjoyce0510
reviewed
Aug 19, 2022
| return ( | ||
| (source === 'MANUAL_INGESTION_SOURCE' && 'Manual Execution') || | ||
| (source === 'SCHEDULED_INGESTION_SOURCE' && 'Scheduled Execution') || | ||
| (source === MANUAL_INGESTION_SOURCE && 'Manual Execution') || |
jjoyce0510
reviewed
Aug 19, 2022
| indentSize: 0, | ||
| }} | ||
| pagination={false} | ||
| <IngestionSourceTable |
Collaborator
There was a problem hiding this comment.
This is much cleaner- thank you!
jjoyce0510
reviewed
Aug 19, 2022
| cliIngestion: source.config.executorId === CLI_EXECUTOR_ID, | ||
| })); | ||
|
|
||
| return ( |
jjoyce0510
reviewed
Aug 19, 2022
| } | ||
| `; | ||
|
|
||
| export function TypeColumn(type: string, record: any) { |
Collaborator
There was a problem hiding this comment.
I think we should do this for all of our tables. Really like splitting columns out like this
jjoyce0510
approved these changes
Aug 19, 2022
Collaborator
jjoyce0510
left a comment
jjoyce0510
left a comment
There was a problem hiding this comment.
This is a model PR. You solved the problem AND made the code much easier to read & maintain. Huge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds necessary checks and styles for displaying CLI based ingestion sources in the managed ingestion list in the UI. If it's from CLI, disable the execute button, only allow them to view their recipe (not edit), and have a few small styling changes.
The VAST majority of the diff here is from refactoring. If you view the changes by commit, this will be much easier to review.
Some screenshots:
one snowflake CLI ingestion source
when you expand its executions
When you click the "View" button for CLI sources - read-only viewer of the recipe
Checklist