test: use supported kernel session timezone - #529
Merged
Merged
Conversation
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: 1 Low
Test-only change swapping an unsupported spark.sql.session.timeZone conf for the supported TIMEZONE session parameter and asserting current_timezone() reflects it — a solid improvement that actually verifies forwarding. One low note: unlike the sibling execute tests, this one doesn't wrap execute/fetch in try/finally, so a failing assertion leaks the operation/session/client.
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
cathleeny
approved these changes
Sep 23, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the supported
TIMEZONESQL session parameter in the kernel E2E test and assertcurrent_timezone()reflects the configured value. databricks-sql-kernel#303 removed the kernel-side session configuration allowlist, exposing that the previousspark.sql.session.timeZonetest key is unsupported by the server.Validation: TypeScript build check, ESLint, Prettier, and diff checks.