Bump Terraform provider from v1.124.0 to v1.125.0 - #6246
Conversation
## Changes Bump the pinned Databricks Terraform provider from v1.124.0 to v1.125.0. Notable schema changes: - The provider no longer issues a `GET /api/2.0/preview/scim/v2/Me` request during deploy/destroy/plan. ## Tests Acceptance goldens regenerated via `./task test-update`. Co-authored-by: Isaac
| Type string `json:"type,omitempty"` | ||
| Value string `json:"value,omitempty"` | ||
| } | ||
|
|
There was a problem hiding this comment.
Apparently. From Claude:
What changed: The Terraform provider v1.125.0 stopped issuing GET /api/2.0/preview/scim/v2/Me (a "current user" identity lookup) during deploy/destroy/plan. All the golden edits are just removals of that one request.
Why only the user_agent test: I grepped every acceptance golden that mentions scim/v2/Me. Of all of them, acceptance/bundle/user_agent/ is the only place where that request is recorded with the databricks-tf-provider/... User-Agent — i.e. the only test that records and asserts on requests the provider itself makes. That's literally its purpose: enumerate every request and its User-Agent string, provider-issued ones included. Every other scim/v2/Me hit in the tree is either:
- a CLI-issued call (the CLI's own currentuser, different User-Agent) — unaffected by a provider bump, or
- filtered out by other request-recording tests (e.g. secret_scopes only prints //secrets paths), or
- test-infra fixtures (test.toml, script, mock server) — not real recorded requests.
There was a problem hiding this comment.
This is the removal of alert parameters from the TF spec, not the API call.
There was a problem hiding this comment.
sorry, my bad. I thought you're asking about the acceptance test changes!
Let me check why these were removed upstream
There was a problem hiding this comment.
The ResourceAlertV2Parameters field was marked as Private Preview upstream, likely shouldn't have been here in the first place
Integration test reportCommit: 9f00bf2
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 6 slowest tests (at least 2 minutes):
|
| "method": "GET", | ||
| "path": "/.well-known/databricks-config" | ||
| } | ||
| { |
There was a problem hiding this comment.
could you check if new out.requests.deploy.terraform.json is the same as simple/out.requests.deploy.direcr.json? if the same, can be merged into one file.
(for all applicable tests)
There was a problem hiding this comment.
will check and do as follow-up
Integration test reportCommit: fbc8c4a
39 interesting tests: 26 flaky, 6 FAIL, 4 RECOVERED, 2 SKIP, 1 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
## Changes Bump `github.com/databricks/databricks-sdk-go` from v0.166.0 to v0.169.0. - `secrets-uc` graduated out of Public Preview (help text and bundle schema). - Pipeline ingestion fanout options promoted from Private Preview to Beta. - New output-only `resources.jobs.*.trigger_state.pause_status` field. The SDK's breaking removals (iamv2 `InternalId`, catalog provider credential fields) and the `bundledeployments` `State` type changes are not referenced by the CLI, so no code changes were required. > Stacked on databricks#6246 (Terraform provider bump); merge that first. ## Tests Acceptance goldens regenerated via `./task test-update`. This pull request and its description were written by Isaac.
Changes
Bump the pinned Databricks Terraform provider from v1.124.0 to v1.125.0.
Notable schema changes:
GET /api/2.0/preview/scim/v2/Merequest during deploy/destroy/plan.Tests
Acceptance goldens regenerated via
./task test-update.This pull request and its description were written by Isaac.