direct: persist state before long-running waits in DoCreate/DoUpdate - #5391

Draft

denik wants to merge 32 commits into

mainfrom

denik/wait-method-removal

Commits on Aug 5, 2026

direct: replace WaitAfterCreate/WaitAfterUpdate with Engine callback for intermediate state saves
denik
committed
75ace5a
direct/testserver: improve app test realism
denik
committed
709e90e
testserver: remove unused GetWorkspace method
denik
committed
53c27d0
direct: simplify Engine API: SaveState(id, state) replaces SetID+SaveState
denik
committed
532c076
direct: Engine.SaveState takes ctx, returns void; logs I/O failures internally
denik
committed
290095b
direct: save state before wait in postgres and dashboard resources
denik
committed
f45ffe0
direct: save state before publishing dashboard; add acceptance tests
denik
committed
6aacc6d
acceptance/dashboards: normalize ?o=/?w= workspace param in URL replacements
denik
committed
8a934e9
acceptance/dashboards: fix ?o=/?w= workspace param normalization
denik
committed
01b577e
acceptance/dashboards: fix &>> redirect for bash 3.2 compatibility
denik
committed
087e744
acceptance/dashboards: unset MSYS_NO_PATHCONV before fault.py on Windows
denik
committed
3f19239
direct: Engine dedup+logging; dashboard saves draft state as Published=false
denik
committed
b8f56a4
direct: inline WaitAfterCreate/WaitAfterUpdate into sql_warehouse DoCreate/DoUpdate
denik
committed
d135237
acceptance/dashboards: use replace_ids.py and inline plan output in publish-failure-retry
denik
committed
e60f663
direct: save state before wait/publish in sql_warehouse DoCreate and dashboard DoUpdate
denik
committed
37ba9de
direct: save state before wait in model_serving_endpoint DoUpdate
denik
committed
106e36b
direct: revert postgres SaveState (waiter.Name() is the LRO operation, not resource id)
denik
committed
3deeb64
direct: route final Create/Update state saves through Engine
denik
committed
3574599
direct: rename Engine -> StateSaver
denik
committed
250161d
direct: add SaveStateWith helper; avoid double JSON marshal in StateSaver
denik
committed
3bcb95e
direct: fix SaveStateWith parameter order (ctx first)
denik
committed
3e5fc24
direct: use SaveStateWith in app DoCreate to prevent un-deployed app
denik
committed
ed4de44
acceptance: move ETAG replacement from parent dashboard test.toml to per-test
denik
committed
51d0012
direct: add StateSaver parameter to genie_space DoCreate and DoUpdate
denik
committed
9260b0e
direct: revert SaveStateWith from dashboard DoUpdate; add stale-content test
denik
committed
5c982db
direct: add StateSaver parameter to postgres_database and postgres_role DoCreate/DoUpdate
denik
committed
dabe0cd
direct: adapt instance_pool/job_run DoCreate/DoUpdate to StateSaver signature
denik
committed
3ba6c4f
direct: fix README reference to renamed StateSaver type
denik
committed
fb2cbd5
direct: drop RedactSensitiveFields from state save paths
denik
committed
4c2736d
acceptance/dashboards: drop wide etag regexes, rely on precise ACC_REPLS
denik
committed
51cee66
direct: save dashboard state before publishing in DoUpdate
denik
committed
8c1c43a
acceptance/postgres: update goldens for uncorrupted duration state
denik
committed
060ad91