Skip to content

Remove \r from new line print statments#509

Merged
shreyas-goenka merged 1 commit into
mainfrom
remove-carraige
Jun 22, 2023
Merged

Remove \r from new line print statments#509
shreyas-goenka merged 1 commit into
mainfrom
remove-carraige

Conversation

@shreyas-goenka
Copy link
Copy Markdown
Contributor

@shreyas-goenka shreyas-goenka commented Jun 21, 2023 •
edited by pietern
Loading

Changes

Removes carriage character from new line prints for json output mode and sync events

Tests

Manually

@shreyas-goenka
Copy link
Copy Markdown
Contributor Author

shreyas-goenka commented Jun 21, 2023

new line characters are printed properly

C:\Users\shreyas.goenka\Desktop>cli fs ls dbfs:/ --output=json
[
  {
    "name":"FileStore",
    "is_directory":true,
    "size":0,
    "last_modified":"2023-06-05T13:01:35Z"
  },
  {
    "name":"Filestore",
    "is_directory":true,
    "size":0,
    "last_modified":"2023-03-26T19:05:22Z"
  },
  {

C:\Users\shreyas.goenka\Desktop>cli fs cp file:/C:\Users\shreyas.goenka\Desktop\dabs file:/C:\Users\shreyas.goenka\Desktop\bricks-fs-cp -r --output=json
{
  "source_path":"\\Users\\shreyas.goenka\\Desktop\\dabs/.databricks/bundle/default/bin/terraform.exe",
  "target_path":"\\Users\\shreyas.goenka\\Desktop\\bricks-fs-cp/.databricks/bundle/default/bin/terraform.exe",
  "type":"FILE_SKIPPED"
}
{
  "source_path":"\\Users\\shreyas.goenka\\Desktop\\dabs/.databricks/bundle/default/sync-snapshots/dc3f4996ac5d5868.json",
  "target_path":"\\Users\\shreyas.goenka\\Desktop\\bricks-fs-cp/.databricks/bundle/default/sync-snapshots/dc3f4996ac5d5868.json",
  "type":"FILE_SKIPPED"
}
{

@shreyas-goenka shreyas-goenka requested review from nfx and pietern June 21, 2023 16:28
@shreyas-goenka shreyas-goenka enabled auto-merge (squash) June 22, 2023 11:46
@shreyas-goenka shreyas-goenka removed the request for review from nfx June 22, 2023 11:46
@shreyas-goenka shreyas-goenka disabled auto-merge June 22, 2023 11:47
@shreyas-goenka shreyas-goenka merged commit f2a2d05 into main Jun 22, 2023
This was referenced Jun 23, 2023
Closed
Merged
pietern added a commit that referenced this pull request Jun 28, 2023
@pietern
Release v0.200.1 (#532)
f42279f 
## Changes

CLI:
* Add --absolute flag for ls command
([#508](#508)).
* Add dbfs scheme prefix to paths in cp command output
([#516](#516)).
* Add provider detection to the repos create command
([#528](#528)).
* Added configure-cluster flag for auth login
([#500](#500)).
* Added prompts for Databricks profile for auth login command
([#502](#502)).
* Allow specifying repo by path for repos commands
([#526](#526)).
* Decode contents by default in workspace export command
([#531](#531)).
* Fixed jobs create command to only accept JSON payload
([#498](#498)).
* Make local files default for fs commands
([#506](#506)).
* Remove \r from new line print statments
([#509](#509)).
* Remove extra call to filer.Stat in dbfs filer.Read
([#515](#515)).
* Update alerts command integration test
([#512](#512)).
* Update variable regex to support hyphens
([#503](#503)).

Bundles:
* Add DATABRICKS_BUNDLE_TMP env variable
([#462](#462)).
* Update Terraform provider schema structs
([#504](#504)).

Dependencies:
* Bump github.com/databricks/databricks-sdk-go from
0.9.1-0.20230614092458-b5bbc1c8dabb to 0.10.0
([#497](#497)).

Internal:
* Use direct download for workspace filer read
([#514](#514)).
denik pushed a commit that referenced this pull request May 20, 2026
@shreyas-goenka
Remove \r from new line print statments (#509)
83e41c1 
## Changes
Removes carriage character from new line prints for json output mode and
sync events

## Tests
Manually
denik pushed a commit that referenced this pull request May 20, 2026
@pietern
Release v0.200.1 (#532)
89900b2 
## Changes

CLI:
* Add --absolute flag for ls command
([#508](#508)).
* Add dbfs scheme prefix to paths in cp command output
([#516](#516)).
* Add provider detection to the repos create command
([#528](#528)).
* Added configure-cluster flag for auth login
([#500](#500)).
* Added prompts for Databricks profile for auth login command
([#502](#502)).
* Allow specifying repo by path for repos commands
([#526](#526)).
* Decode contents by default in workspace export command
([#531](#531)).
* Fixed jobs create command to only accept JSON payload
([#498](#498)).
* Make local files default for fs commands
([#506](#506)).
* Remove \r from new line print statments
([#509](#509)).
* Remove extra call to filer.Stat in dbfs filer.Read
([#515](#515)).
* Update alerts command integration test
([#512](#512)).
* Update variable regex to support hyphens
([#503](#503)).

Bundles:
* Add DATABRICKS_BUNDLE_TMP env variable
([#462](#462)).
* Update Terraform provider schema structs
([#504](#504)).

Dependencies:
* Bump github.com/databricks/databricks-sdk-go from
0.9.1-0.20230614092458-b5bbc1c8dabb to 0.10.0
([#497](#497)).

Internal:
* Use direct download for workspace filer read
([#514](#514)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pietern pietern pietern approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shreyas-goenka @pietern