Skip to content

Added support for creating SQL warehouses in DABs#3129

Merged
andrewnester merged 25 commits into
mainfrom
feature/sql-warehouse
Jul 16, 2025
Merged

Added support for creating SQL warehouses in DABs#3129
andrewnester merged 25 commits into
mainfrom
feature/sql-warehouse

Conversation

@andrewnester

@andrewnester andrewnester commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Changes

Added support for creating SQL warehouses in DABs

Why

SQL warehouses are commonly used and supporting them in DABs allows for even better automation.

Tests

Added acceptance tests

denik
denik reviewed Jun 26, 2025
View reviewed changes
Comment thread acceptance/bundle/deploy/sql_warehouse/test.toml Outdated
@andrewnester andrewnester force-pushed the feature/sql-warehouse branch from 48ef00c to 3d5cb44 Compare July 2, 2025 10:12
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Run: 16319495265

Env ✅‌pass 🔄‌flaky 🙈‌skip
✅‌ aws linux 302 426
✅‌ aws windows 303 425
🔄‌ aws-ucws linux 400 8 326
🔄‌ aws-ucws windows 400 9 325
✅‌ azure linux 302 425
✅‌ azure windows 303 424
✅‌ azure-ucws linux 410 323
✅‌ azure-ucws windows 411 322
✅‌ gcp linux 301 427
✅‌ gcp windows 302 426
9 failing tests:
Test Name aws-ucws linux aws-ucws windows
TestAccept/bundle/deploy/dashboard/detect-change 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deploy/dashboard/nested-folders 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deploy/dashboard/simple 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deploy/dashboard/simple_outside_bundle_root 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deploy/dashboard/simple_syncroot 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deployment/bind/dashboard 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deployment/bind/dashboard/recreation 🔄‌flaky 🔄‌flaky
TestDashboardAssumptions_WorkspaceImport 🔄‌flaky 🔄‌flaky
TestFetchRepositoryInfoAPI_FromRepo ✅‌pass 🔄‌flaky

@andrewnester andrewnester requested a review from denik July 2, 2025 12:42
shreyas-goenka
shreyas-goenka reviewed Jul 10, 2025
View reviewed changes

@shreyas-goenka shreyas-goenka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Few comments, but everything else looks good to me.

Comment thread bundle/config/resources/sql_warehouses.go
Comment thread bundle/internal/schema/annotations.yml Outdated
Comment thread bundle/terranova/tnresources/sql_warehouse.go Outdated
Comment thread libs/testserver/sql_warehouses.go Outdated
Comment thread libs/testserver/sql_warehouses.go Outdated
Comment thread libs/testserver/sql_warehouses.go
}
}

func (s *FakeWorkspace) SqlDataSourcesList(req Request) Response {

@shreyas-goenka shreyas-goenka Jul 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do these API calls come from? Terraform? This is a legacy version of the list warehouse API.

@andrewnester andrewnester Jul 14, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this comes from terraform now

Comment thread bundle/terranova/tnresources/sql_warehouse.go
pietern
pietern reviewed Jul 11, 2025
View reviewed changes
Comment thread bundle/config/resources/sql_warehouses.go
Comment thread bundle/config/resources/sql_warehouses.go Outdated
Comment thread bundle/internal/schema/annotations_openapi.yml Outdated
Comment thread bundle/internal/schema/annotations_openapi.yml
Comment thread bundle/terranova/tnresources/sql_warehouse.go
Comment thread libs/structwalk/walktype_test.go
testStruct(t,
reflect.TypeOf(config.Root{}),
3500, 3600, // 3516 at this time
3600, 3700, // 3625 at this time

@pietern pietern Jul 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test should be updated to not require some arbitrary bounds update every so often (not this PR).

shreyas-goenka
shreyas-goenka approved these changes Jul 16, 2025
View reviewed changes

@shreyas-goenka shreyas-goenka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please take a look at the one comment.

Comment thread bundle/internal/schema/annotations_openapi.yml
pietern
pietern approved these changes Jul 16, 2025
View reviewed changes
Comment thread bundle/internal/schema/annotations.yml
"description": |-
The SQL warehouse definitions for the bundle, where each key is the name of the warehouse.
"markdown_description": |-
The SQL warehouse definitions for the bundle, where each key is the name of the warehouse. See [\_](/dev-tools/bundles/resources.md#sql_warehouses).

@pietern pietern Jul 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure to work with Julia to get this section added to the docs?

@andrewnester andrewnester added this pull request to the merge queue Jul 16, 2025
Merged via the queue into main with commit 75838aa Jul 16, 2025
13 checks passed
@andrewnester andrewnester deleted the feature/sql-warehouse branch July 16, 2025 13:31
deco-sdk-tagging Bot added a commit that referenced this pull request Jul 16, 2025
@deco-sdk-tagging
[Release] Release v0.260.0
78c0234 
## Release v0.260.0

### Notable Changes
* Added support for creating SQL warehouses in DABs ([#3129](#3129))

### Dependency updates
* Upgrade Go SDK to 0.75.0 ([#3256](#3256))

### CLI
* Add `databricks psql` command to connect to Lakebase with a single command ([#3128](#3128))

### Bundles

 * Jobs that use cluster policy default values for their cluster configuration now correctly update those defaults on every deployment ([#3255](#3255)).
 * Add upper and lower helper methods for bundle templates ([#3242](#3242))
denik pushed a commit that referenced this pull request May 20, 2026
@andrewnester
Added support for creating SQL warehouses in DABs (#3129)
e90cb81 
## Changes
Added support for creating SQL warehouses in DABs

## Why
SQL warehouses are commonly used and supporting them in DABs allows for
even better automation.

## Tests
Added acceptance tests

<!-- If your PR needs to be included in the release notes for next
release,
add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
denik pushed a commit that referenced this pull request May 20, 2026
@deco-sdk-tagging
[Release] Release v0.260.0
8e439cf 
## Release v0.260.0

### Notable Changes
* Added support for creating SQL warehouses in DABs ([#3129](#3129))

### Dependency updates
* Upgrade Go SDK to 0.75.0 ([#3256](#3256))

### CLI
* Add `databricks psql` command to connect to Lakebase with a single command ([#3128](#3128))

### Bundles

 * Jobs that use cluster policy default values for their cluster configuration now correctly update those defaults on every deployment ([#3255](#3255)).
 * Add upper and lower helper methods for bundle templates ([#3242](#3242))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pietern pietern pietern approved these changes

@shreyas-goenka shreyas-goenka shreyas-goenka approved these changes

@anton-107 anton-107 Awaiting requested review from anton-107

@denik denik Awaiting requested review from denik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andrewnester @eng-dev-ecosystem-bot @pietern @denik @shreyas-goenka